[webkit-reviews] review requested: [Bug 25673] [GTK] ATs should be able to select/unselect text : [Attachment 67208] Path proposal + Unit tests

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25673: [GTK] ATs should be able to select/unselect text
https://bugs.webkit.org/show_bug.cgi?id=25673

Attachment 67208: Path proposal + Unit tests
https://bugs.webkit.org/attachment.cgi?id=67208&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #11)
> (From update of attachment 67206 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=67206&action=prettypatch
> 
> > WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:112
> > +	 if (!textLength) {
> This should probably be an early return.
> 
> > WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:346
> > +{
> I like this a lot better, but I'd rather see early returns. :/
> 
> Looks good! r=me, but please switch to using early returns before landing.

Here you have a new version.

BTw, I'm not asking for cq+ for now because we must make sure patch for 26991
are landed first (hence, I'll ask for cq+ later)