[webkit-reviews] review granted: [Bug 25673] [GTK] ATs should be able to select/unselect text : [Attachment 67206] Path proposal + Unit tests

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 25673: [GTK] ATs should be able to select/unselect text
https://bugs.webkit.org/show_bug.cgi?id=25673

Attachment 67206: Path proposal + Unit tests
https://bugs.webkit.org/attachment.cgi?id=67206&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67206&action=prettypatch

> WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:112
> +    if (!textLength) {
This should probably be an early return.

> WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:346
> +{
I like this a lot better, but I'd rather see early returns. :/

Looks good! r=me, but please switch to using early returns before landing.