[webkit-reviews] review granted: [Bug 45550] [GTK] Placement new / manual destructor invocation should be used on private GObject memory : [Attachment 67200] Patch making this change for WebKitWebView

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 45550: [GTK] Placement new / manual destructor invocation should be used on
private GObject memory
https://bugs.webkit.org/show_bug.cgi?id=45550

Attachment 67200: Patch making this change for WebKitWebView
https://bugs.webkit.org/attachment.cgi?id=67200&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>

>-    if (priv->tooltipText) {
>-	  gtk_tooltip_set_text(tooltip, priv->tooltipText);
>+    if (priv->tooltipText.length() > 0) {

Mmm, should use isEmpty() for consistency sake?

>+	  gtk_tooltip_set_text(tooltip, priv->tooltipText.data());
>	  return TRUE;
>     }
> 


Looks great otherwise.