[webkit-reviews] review requested: [Bug 45533] SVG text chunk concept needs to be integrated in the InlineBox structure : [Attachment 67171] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 10 05:40:11 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 45533: SVG text chunk concept needs to be integrated in the InlineBox
structure
https://bugs.webkit.org/show_bug.cgi?id=45533

Attachment 67171: Patch
https://bugs.webkit.org/attachment.cgi?id=67171&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Tried to keep this patch as small as possible. We're now computing the text
layout twice. The new code path does all compuations before the inline box tree
is created, the old code does it again, after the creation of the inline box
tree. This duplication is intended, and will be removed in follow-up patches.

I didn't want to mix removing/rewriting the old layout text code, otherwhise
the patch size would get huge.


More information about the webkit-reviews mailing list