[webkit-reviews] review denied: [Bug 45387] [GTK] Implement ContextMenu::itemCount : [Attachment 66891] itemCount implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 10 02:04:34 PDT 2010
chris fleizach <cfleizach at apple.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 45387: [GTK] Implement ContextMenu::itemCount
https://bugs.webkit.org/show_bug.cgi?id=45387
Attachment 66891: itemCount implementation
https://bugs.webkit.org/attachment.cgi?id=66891&action=review
------- Additional Comments from chris fleizach <cfleizach at apple.com>
> /*
> * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
> * Copyright (C) 2008 Christian Dywan <christian at imendio.com>
> + * Copyright (C) 2010 Igalia S.L
> *
> * Redistribution and use in source and binary forms, with or without
Coding guidelines state
Develop your changes
If you make substantive changes to a file, you may wish to add a copyright line
for yourself or for the company on whose behalf you work.
I don't think this is a substantive change.
You should also have a layout test here, especially because new functionality
is being exposed
More information about the webkit-reviews
mailing list