[webkit-reviews] review granted: [Bug 45498] [FileSystem] Do not call EntriesCallback more than once if there're no entries. : [Attachment 67103] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 9 23:00:34 PDT 2010


Dumitru Daniliuc <dumi at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 45498: [FileSystem] Do not call EntriesCallback more than once if there're
no entries.
https://bugs.webkit.org/show_bug.cgi?id=45498

Attachment 67103: Patch
https://bugs.webkit.org/attachment.cgi?id=67103&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67103&action=prettypatch

r=me, but please address the comments before submitting.

> WebCore/fileapi/FileSystemCallbacks.cpp:150
> +	   if (!hasMore && hadEntries) {
i don't think you need the hadEntries variable. can you just use: if (!hasMore
&& !m_entries->isEmpty()) and clear m_entries after the if-block?

> WebCore/fileapi/FileSystemCallbacks.cpp:151
>	       // If there're no more entries, call back once more with an
empty array.
update the comment please.


More information about the webkit-reviews mailing list