[webkit-reviews] review requested: [Bug 42815] getBoundingClientRect Broken for SVG Elements : [Attachment 67155] Fix and layout test, take 3

[bugzilla-daemon at webkit.org]

Cosmin Truta <ctruta at chromium.org> has asked  for review:
Bug 42815: getBoundingClientRect Broken for SVG Elements
https://bugs.webkit.org/show_bug.cgi?id=42815

Attachment 67155: Fix and layout test, take 3
https://bugs.webkit.org/attachment.cgi?id=67155&action=review

------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
Niko,
Here is the old patch with new tests, as you suggested. The test include an
unstretched and a stretched rectangle, as well as two overflown rectangles (a
hidden one, and a scrolled one).

I did not know how to test zooming. When I added tests for
getBoundingClientRect to an existing SVG zooming test, I was still getting the
initial rectangle coordinates, before zooming. The getBoundingClientRect
function does work correctly, for example, when I run that test in the browser,
I zoom then I click the refresh button, the coordinates are scaled as expected.
However, when zooming using testPageZoom.js, without hitting the refresh button
or doing other sorts of UI interaction, the rectangle coordinates are not
scaled. If you wish, I can show you the example that I'm using.

And there is another thing: getBoundingClientRect works well on various SVG
elements that I tried, except <text>. (In comparison, getBBox does work on
<text> under Chromium, and both getBBox and getBoundingClientRect work well on
<text> under Firefox.) Would it be possible to have my patch accepted, and
allow me to work on the remaining issue, separately, so that I keep the code
chunks separate and reasonably small?

Best regards,
Cosmin