[webkit-reviews] review granted: [Bug 45508] Move functions from Frame to SelectionController as planned : [Attachment 67130] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 45508: Move functions from Frame to SelectionController as planned
https://bugs.webkit.org/show_bug.cgi?id=45508

Attachment 67130: Patch
https://bugs.webkit.org/attachment.cgi?id=67130&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67130&action=prettypatch

Please try not to break the chromium build when landing.  Thanks!

> WebKit/chromium/src/WebFrameImpl.cpp:1716
> +	   return IntRect(frame()->selection()->selectionBounds(false));
Not just selection()->bounds(false) ?

> WebKit/mac/WebView/WebHTMLView.mm:6052
> +	   coreFrame->selection()->selectionTextRects(list,
SelectionController::RespectTransforms);
selection()->selectionTextRects => selection()->textRects ?