[webkit-reviews] review granted: [Bug 45514] AX: Add methods used to prevent a Chromium renderer crash : [Attachment 67143] Add methods to WebAccessibilityObject in Chromium port

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted
chris.guillory at google.com's request for review:
Bug 45514: AX: Add methods used to prevent a Chromium renderer crash
https://bugs.webkit.org/show_bug.cgi?id=45514

Attachment 67143: Add methods to WebAccessibilityObject in Chromium port
https://bugs.webkit.org/attachment.cgi?id=67143&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67143&action=prettypatch

I feel like we're doing some bad, bad things here. Why are we checking for
validity of the renderer? Shouldn't the AX tree take care of this?

> WebKit/chromium/src/WebAccessibilityObject.cpp:342
> +	   return 0;
return false;

> WebKit/chromium/src/WebAccessibilityObject.cpp:351
> +	   return 0;
return false;