[webkit-reviews] review granted: [Bug 45516] [chromium] Chromium mac build should exclude all Skia files in platform/graphics/skia/, not just some : [Attachment 67144] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 45516: [chromium] Chromium mac build should exclude all Skia files in
platform/graphics/skia/, not just some
https://bugs.webkit.org/show_bug.cgi?id=45516

Attachment 67144: Patch
https://bugs.webkit.org/attachment.cgi?id=67144&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67144&action=prettypatch

Basically, as long as you've built this locally it seems fine to land. If you
haven't built it locally then I wouldn't land it until you've verified the
change works.

> WebCore/WebCore.gyp/WebCore.gyp:-1248
> -
There is another exclusion of
../platform/graphics/skia/FontCustomPlatformData.cpp higher up. Should that be
removed as well?