[webkit-reviews] review granted: [Bug 45440] [FileSystem] Add File and FileWriter accessor methods in FileEntry : [Attachment 67122] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 9 18:21:53 PDT 2010


Jian Li <jianli at chromium.org> has granted Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 45440: [FileSystem] Add File and FileWriter accessor methods in FileEntry
https://bugs.webkit.org/show_bug.cgi?id=45440

Attachment 67122: Patch
https://bugs.webkit.org/attachment.cgi?id=67122&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67122&action=prettypatch

> WebCore/ChangeLog:8
> +	   Adding FileEntry.file() and FileEntry.createWrite() methods in
FileEntry.
You can remove "FileEntry." prefix to simplify the sentence. Also, better to
have "Added" for "Adding".

> WebCore/fileapi/FileWriterCallback.idl:39
>  
Extra line at the end of the file?


More information about the webkit-reviews mailing list