[webkit-reviews] review granted: [Bug 45503] [chromium] Clear only the uploaded portion of the software backing store when in mixed mode : [Attachment 67121] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 45503: [chromium] Clear only the uploaded portion of the software backing
store when in mixed mode
https://bugs.webkit.org/show_bug.cgi?id=45503

Attachment 67121: Patch
https://bugs.webkit.org/attachment.cgi?id=67121&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67121&action=prettypatch

Looks good overall with a couple of minor issues that can be fixed upon
landing.

> WebCore/platform/graphics/gpu/Texture.cpp:129
> +	   for (int y = 0; y < height; y++) {
Apparently WebKit style prefers preincrement (++y rather than y++). Note that
changing this wouldn't change the functionality of the loop.

> WebCore/platform/graphics/skia/PlatformContextSkia.cpp:734
>	       // Start compositing into the empty canvas.
This comment should probably change.

> WebCore/platform/graphics/skia/PlatformContextSkia.cpp:818
> +    SkRect bounds = {m_softwareDirtyRect.x(), m_softwareDirtyRect.y(),
m_softwareDirtyRect.right(), m_softwareDirtyRect.bottom()};
There's a casting operator SkRect() on FloatRect when compiled against Skia.