[webkit-reviews] review granted: [Bug 45026] REGRESSION: applying new font size causes font-size outside selection to change : [Attachment 67109] fixed StyleChange::extractTextStyles

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 45026: REGRESSION: applying new font size causes font-size outside
selection to change
https://bugs.webkit.org/show_bug.cgi?id=45026

Attachment 67109: fixed StyleChange::extractTextStyles
https://bugs.webkit.org/attachment.cgi?id=67109&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67109&action=prettypatch

> LayoutTests/editing/deleting/delete-br-012-expected.txt:22
> -|	 size="6"
> -|	 <span>
> -|	   class="Apple-style-span"
> -|	   style="font-size: 24px;"
> -|	   <#selection-caret>
> -|	   <br>
> +|	 size="5"
> +|	 <#selection-caret>
> +|	 <br>
So again, this is an intentional change from 6 to 5, right?

Looks sane.  I trust you.