[webkit-reviews] review granted: [Bug 45211] Add AudioDSPKernelProcessor files : [Attachment 66758] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 9 14:32:20 PDT 2010


Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 45211: Add AudioDSPKernelProcessor files
https://bugs.webkit.org/show_bug.cgi?id=45211

Attachment 66758: Patch
https://bugs.webkit.org/attachment.cgi?id=66758&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Looks fine to me. I hope that the JavaScript code which drives some of these
classes can't trigger the assertions throughout this code simply by
reconfiguring the audio graph, and that the assertions firing would imply a bug
in the audio engine itself.


More information about the webkit-reviews mailing list