[webkit-reviews] review denied: [Bug 45440] [FileSystem] Add File and FileWriter accessor methods in FileEntry : [Attachment 66999] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 45440: [FileSystem] Add File and FileWriter accessor methods in FileEntry
https://bugs.webkit.org/show_bug.cgi?id=45440

Attachment 66999: Patch
https://bugs.webkit.org/attachment.cgi?id=66999&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66999&action=prettypatch

> WebCore/WebCore.vcproj/WebCore.vcproj:4826
> +				<FileConfiguration
The FileConfiguration parts should not be included because they're used to
exclude the file. I think we still want the file to be included in the build
target, though the feature is not enabled for Windows.

> WebCore/fileapi/FileWriterCallback.idl:33
> +	   Conditional=FILE_SYSTEM&FILE_WRITER,
This condition "FILE_SYSTEM&FILE_WRITER" seems not to be consistent with
"ENABLE(FILE_SYSTEM)" used in FileWriterCallback.h.