[webkit-reviews] review granted: [Bug 45481] Inline FrameLoader::committedLoad into its one caller : [Attachment 67072] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 9 12:11:08 PDT 2010
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 45481: Inline FrameLoader::committedLoad into its one caller
https://bugs.webkit.org/show_bug.cgi?id=45481
Attachment 67072: Patch
https://bugs.webkit.org/attachment.cgi?id=67072&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
It appears you're missing an include?
../../../WebCore/loader/DocumentLoader.cpp: In member function 'void
WebCore::DocumentLoader::commitLoad(const char*, int)':
../../../WebCore/loader/DocumentLoader.cpp:285: error: invalid use of
incomplete type 'struct WebCore::FrameLoaderClient'
../../../WebCore/loader/SubframeLoader.h:45: error: forward declaration of
'struct WebCore::FrameLoaderClient'
Otherwise seems fine.
More information about the webkit-reviews
mailing list