[webkit-reviews] review requested: [Bug 45249] Add cubic curve classifier : [Attachment 67074] Revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 9 11:54:17 PDT 2010


Kenneth Russell <kbr at google.com> has asked  for review:
Bug 45249: Add cubic curve classifier
https://bugs.webkit.org/show_bug.cgi?id=45249

Attachment 67074: Revised patch
https://bugs.webkit.org/attachment.cgi?id=67074&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
It turns out that while converting this code to use FloatPoint3D I introduced a
regression; the 2D points are considered to be homogeneous, meaning that during
conversion to 3D their "z" coordinate (actually the "w" coordinate in an (x, y,
w) triplet) needs to be set to 1.0. Please re-review. Also fixed formatting nit
above.


More information about the webkit-reviews mailing list