[webkit-reviews] review granted: [Bug 45479] Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT : [Attachment 67065] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 45479: Implement layoutTestController.dumpResourceResponseMIMETypes in
Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45479

Attachment 67065: Patch
https://bugs.webkit.org/attachment.cgi?id=67065&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67065&action=prettypatch

> WebKitTools/DumpRenderTree/chromium/LayoutTestController.h:108
> +    // This function sets a flag that tells the test_shell to dump the MIME
type
> +    // for each resource that was loaded. It takes no arguments, and ignores
any
> +    // that may be present.
> +    void dumpResourceResponseMIMETypes(const CppArgumentList&, CppVariant*
result);
Nit: remove |result|

> WebKitTools/DumpRenderTree/chromium/WebViewHost.cpp:922
> +	   fputs(" - didReceiveResponse ", stdout);
> +	   printResponseDescription(response);
> +	   fputs("\n", stdout);
Nit: Can we use puts instead of fputs?

> WebKitTools/DumpRenderTree/chromium/WebViewHost.cpp:930
> +	       // Simulate NSURLResponse's mapping of empty/unknown MIME types
to application/octet-stream
> +	       mimeType.isEmpty() ? "application/octet-stream" :
mimeType.utf8().data());
Same question about mimeType.utf().data(), do we need to null terminate it?