[webkit-reviews] review granted: [Bug 45449] Extract the code to find special ancestors in createMarkup into a function : [Attachment 67014] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 45449: Extract the code to find special ancestors in createMarkup into a
function
https://bugs.webkit.org/show_bug.cgi?id=45449

Attachment 67014: Patch
https://bugs.webkit.org/attachment.cgi?id=67014&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67014&action=prettypatch

> WebCore/editing/markup.cpp:961
> +    Node* specialCommonAncestor = 0;
> +    if (shouldAnnotate == AnnotateForInterchange) {
> +	   specialCommonAncestor =
ancestorToRetainStructureAndAppearance(commonAncestor);
Nit: You may want to copy the comment that was around here about which ancestor
you want to include.  It's not obvious why we might want the
specialCommonAncestor (ie., what makes it special).  Maybe the comment should
just go above this function.