[webkit-reviews] review granted: [Bug 21033] queryCommandValue('FontSize') returns pixel values instead of IE font numbers : [Attachment 66997] fixed per Darin's comments

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 21033: queryCommandValue('FontSize') returns pixel values instead of IE
font numbers
https://bugs.webkit.org/show_bug.cgi?id=21033

Attachment 66997: fixed per Darin's comments
https://bugs.webkit.org/attachment.cgi?id=66997&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    bool useFixedFontDefaultSize() const;

I’m glad you renamed this to be more specific. For the future, it’s not great
to have functions that sound like they will take an action such as "use the
fixed-font default size" that really mean the caller "should use the fixed-font
default size". That’s why you’ll often see the word “should” in the name of
boolean-returning functions. The word “use” makes the function be a verb phrase
and sound like it will take action.