[webkit-reviews] review granted: [Bug 41209] Fill mode is broken with multiple keyframes : [Attachment 67021] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 9 10:27:22 PDT 2010
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 41209: Fill mode is broken with multiple keyframes
https://bugs.webkit.org/show_bug.cgi?id=41209
Attachment 67021: Patch
https://bugs.webkit.org/attachment.cgi?id=67021&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
Can the tests use animation-test-helpers.js? If the pause stuff doesn't work
with fill modes, we should fix it.
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +2010-09-09 Dean Jackson <dino at apple.com>
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + Fill mode is broken with multiple keyframes
> + https://bugs.webkit.org/show_bug.cgi?id=41209
> +
This needs to say what the problem was, and how you fixed it.
r=me, but it would be nice of the tests could be more cookie-cutter, and make
use of the pause API so they run faster.
More information about the webkit-reviews
mailing list