[webkit-reviews] review requested: [Bug 25321] RLE/LRE characters are removed from any text entered into a text box (either using a keyboard or by pasting) : [Attachment 67049] patch w/ layout test

[bugzilla-daemon at webkit.org]

Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 25321: RLE/LRE characters are removed from any text entered into a text box
(either using a keyboard or by pasting)
https://bugs.webkit.org/show_bug.cgi?id=25321

Attachment 67049: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=67049&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
1. I've tried to change Position::upstream(), Position::downstream(), and
Position::isCandidate() universally, but it breaks editing/selection/home-end
(test case 16)	and editing/selection/extend-selection (test case 17) tests,
where the Unicode bidi control characters are the first characters in the
element. In those situation, we should allow the control characters to be
ignored.
So, I am adding a flag to differentiate the insert/cut/copy/paste operations
from others.

2. Currently, the patch only fixes problem in insertion and paste. Since
cut/copy does not work correctly, the result of the paste in the test case is
actually wrong (although paste itself works correctly).
If the approach is the right one, I will fix the problem in cut/copy as well.