[webkit-reviews] review denied: [Bug 45092] [chromium] Accelerated Compositing: screen garbage when scrolling : [Attachment 66961] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Nat Duca
<nduca at chromium.org>'s request for review:
Bug 45092: [chromium] Accelerated Compositing: screen garbage when scrolling
https://bugs.webkit.org/show_bug.cgi?id=45092

Attachment 66961: Patch
https://bugs.webkit.org/attachment.cgi?id=66961&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66961&action=prettypatch

> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:275
> +    //
ASSERT(static_cast<int>(CGBitmapContextGetWidth(m_rootLayerCGContext.get())) ==
updateRect.width() &&
static_cast<int>(CGBitmapContextGetHeight(m_rootLayerCGContext.get())) ==
updateRect.height());
is there a reason for commenting out this assertion?  should it just be deleted
instead?

> WebKit/chromium/ChangeLog:15
> +	   a pair of methods: paintComposited and
this ChangeLog needs to be revised to correspond to the actual name
of the methods.  you should probably just regenerate it completely
as the list of methods below is also out of date.

> WebKit/chromium/src/WebViewImpl.cpp:956
> +	   doComposite(canvas);
it's not clear why doComposite needs a canvas parameter if wjmaclean's
readback code is going to go below here.

> WebKit/chromium/src/WebViewImpl.cpp:2311
> +void WebViewImpl::doComposite(WebCanvas* canvas)
i'm pretty sure this canvas parameter can be deleted now.

Looking great overall.	Just these few minor issues remaining.