[webkit-reviews] review granted: [Bug 45460] Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree. : [Attachment 67039] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 9 09:04:45 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has granted hans at chromium.org's request for
review:
Bug 45460: Hook up LayoutTestController.setMockDeviceOrientation() in Chromium
DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=45460

Attachment 67039: Patch
https://bugs.webkit.org/attachment.cgi?id=67039&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67039&action=prettypatch

> WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1397
> +    if (arguments.size() < 6 || !arguments[0].isBool() ||
!arguments[1].isNumber()
not sure this needs to be multiple lines

> WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1399
> +				|| !arguments[4].isBool() ||
!arguments[5].isNumber())
use {}'s when the if or the subsequent part is more than one line

> WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1402
> +    WebKit::WebDeviceOrientation orientation(arguments[0].toBoolean(),
arguments[1].toDouble(),
or this

> WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1406
> +    ASSERT(m_deviceOrientationClientMock.get());
dont need .get() I'm pretty sure

r=me


More information about the webkit-reviews mailing list