[webkit-reviews] review requested: [Bug 29268] [Qt] JSVALUE32_64 not works on Windows platform with MinGW compiler : [Attachment 67034] proposed patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has asked  for review:
Bug 29268: [Qt] JSVALUE32_64 not works on Windows platform with MinGW compiler
https://bugs.webkit.org/show_bug.cgi?id=29268

Attachment 67034: proposed patch
https://bugs.webkit.org/attachment.cgi?id=67034&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
I tried JSVALUE32_64 with QtWebKit/Windows/MinGW again, and it works now. :)
I don't know which changeset fixed it in the last 5 months. :)

It works now, so I propose to switch to JSVALUE32_64.
SunSpider will be 1.60x faster, but V8 will be 1.19x slower.

TEST		       COMPARISON	     FROM		  TO	       
 DETAILS
=============================================================================

** TOTAL **:	       1.60x as fast	 971.4ms +/- 3.5%   607.4ms +/- 2.7%   
 significant

=============================================================================

  3d:		       2.90x as fast	 243.8ms +/- 9.3%    84.2ms +/- 9.5%   
 significant
    cube:	       3.02x as fast	 108.6ms +/- 18.4%    36.0ms +/- 21.3% 
   significant
    morph:	       4.06x as fast	  75.6ms +/- 3.0%    18.6ms +/- 3.7%   
 significant
    raytrace:	       2.01x as fast	  59.6ms +/- 4.8%    29.6ms +/- 2.3%   
 significant

  access:	       1.53x as fast	  97.0ms +/- 7.3%    63.2ms +/- 1.6%   
 significant
    binary-trees:      *1.18x as slow*	   7.6ms +/- 9.0%     9.0ms +/- 9.8%   
 significant
    fannkuch:	       *1.41x as slow*	  19.6ms +/- 3.5%    27.6ms +/- 2.5%   
 significant
    nbody:	       3.33x as fast	  64.0ms +/- 9.8%    19.2ms +/- 2.9%   
 significant
    nsieve:	       *1.28x as slow*	   5.8ms +/- 9.6%     7.4ms +/- 9.2%   
 significant

  bitops:	       1.12x as fast	  44.0ms +/- 3.5%    39.2ms +/- 4.1%   
 significant
    3bit-bits-in-byte: *1.94x as slow*	   3.6ms +/- 18.9%     7.0ms +/- 0.0%  
  significant
    bits-in-byte:      *1.21x as slow*	   8.4ms +/- 8.1%    10.2ms +/- 5.5%   
 significant
    bitwise-and:       *1.76x as slow*	   4.2ms +/- 13.2%     7.4ms +/- 9.2%  
  significant
    nsieve-bits:       1.90x as fast	  27.8ms +/- 2.0%    14.6ms +/- 4.7%   
 significant

  controlflow:	       *1.40x as slow*	   4.0ms +/- 0.0%     5.6ms +/- 12.2%  
  significant
    recursive:	       *1.40x as slow*	   4.0ms +/- 0.0%     5.6ms +/- 12.2%  
  significant

  crypto:	       1.72x as fast	  67.6ms +/- 2.8%    39.4ms +/- 24.1%  
  significant
    aes:	       *1.28x as slow*	  20.2ms +/- 2.8%    25.8ms +/- 35.6%  
  significant
    md5:	       3.08x as fast	  23.4ms +/- 2.9%     7.6ms +/- 9.0%   
 significant
    sha1:	       4.00x as fast	  24.0ms +/- 3.7%     6.0ms +/- 0.0%   
 significant

  date: 	       1.10x as fast	  74.8ms +/- 1.4%    68.0ms +/- 2.9%   
 significant
    format-tofte:      1.15x as fast	  40.2ms +/- 1.4%    35.0ms +/- 3.6%   
 significant
    format-xparb:      1.05x as fast	  34.6ms +/- 2.0%    33.0ms +/- 2.7%   
 significant

  math: 	       2.99x as fast	 170.8ms +/- 4.6%    57.2ms +/- 1.8%   
 significant
    cordic:	       4.38x as fast	  57.8ms +/- 9.9%    13.2ms +/- 4.2%   
 significant
    partial-sums:      2.68x as fast	  86.4ms +/- 2.4%    32.2ms +/- 1.7%   
 significant
    spectral-norm:     2.25x as fast	  26.6ms +/- 2.6%    11.8ms +/- 4.7%   
 significant

  regexp:	       1.08x as fast	  22.0ms +/- 0.0%    20.4ms +/- 3.3%   
 significant
    dna:	       1.08x as fast	  22.0ms +/- 0.0%    20.4ms +/- 3.3%   
 significant

  string:	       1.07x as fast	 247.4ms +/- 1.4%   230.2ms +/- 2.1%   
 significant
    base64:	       1.13x as fast	  40.6ms +/- 4.1%    36.0ms +/- 6.5%   
 significant
    fasta:	       -		  38.8ms +/- 12.5%    37.8ms +/- 2.8% 
    tagcloud:	       1.09x as fast	  44.4ms +/- 3.2%    40.8ms +/- 2.5%   
 significant
    unpack-code:       -		  74.6ms +/- 1.9%    73.0ms +/- 2.9% 
    validate-input:    1.15x as fast	  49.0ms +/- 1.8%    42.6ms +/- 1.6%   
 significant



    TEST	     COMPARISON 	   FROM 		TO	      
DETAILS
=============================================================================

** TOTAL **:	 *1.19x as slow*   2009.6ms +/- 2.2%   2387.0ms +/- 1.1%    
significant

=============================================================================

  v8:		 *1.19x as slow*   2009.6ms +/- 2.2%   2387.0ms +/- 1.1%    
significant
    crypto:	 *1.38x as slow*    318.4ms +/- 3.9%	438.2ms +/- 0.3%    
significant
    deltablue:	 *1.18x as slow*    591.8ms +/- 2.6%	696.4ms +/- 1.1%    
significant
    early-boyer: *1.18x as slow*    377.0ms +/- 4.5%	445.4ms +/- 2.6%    
significant
    raytrace:	 1.39x as fast	    268.6ms +/- 6.4%	193.0ms +/- 7.9%    
significant
    richards:	 *1.35x as slow*    453.8ms +/- 0.2%	614.0ms +/- 0.3%    
significant