[webkit-reviews] review denied: [Bug 34250] Web Inspector: Add navigation items into the Elements panel context menu. : [Attachment 67024] [PATCH] Patch with localizedStrings.js diff

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 34250: Web Inspector: Add navigation items into the Elements panel context
menu.
https://bugs.webkit.org/show_bug.cgi?id=34250

Attachment 67024: [PATCH] Patch with localizedStrings.js diff
https://bugs.webkit.org/attachment.cgi?id=67024&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67024&action=prettypatch

> WebCore/ChangeLog:5
> +	   Web Inspector: Add navigation items into the Elements panel context
menu.
Please provide detailed description of the added actions.

> WebCore/inspector/front-end/ElementsTreeOutline.js:293
> +	       var needSeparator = true;
Please declare this variable outside the if block.

> WebCore/inspector/front-end/StylesSidebarPane.js:130
> +	   // Keep these consistent with those added in
WebInspector.ElementsTreeElement.prototype._populateHrefContextMenu().
This code is exactly the same in both places. Please extract it into a utility
function or reassign
WebInspector.ElementsTreeElement.prototype._populateHrefContextMenu function to
WebInspector.StylesSidebarPane.prototype._populateHrefContextMenu like we do in
some other places. Personally I'd prefer the former approach. r- for this.