[webkit-reviews] review requested: [Bug 45446] [EFL] Add setting API to set a local storage database path. : [Attachment 67012] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 9 02:23:39 PDT 2010
Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked for review:
Bug 45446: [EFL] Add setting API to set a local storage database path.
https://bugs.webkit.org/show_bug.cgi?id=45446
Attachment 67012: Patch
https://bugs.webkit.org/attachment.cgi?id=67012&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
The local storage database path is set via setLocalStorageDatabsePath() of
Settings class. Thus, we should use settings instance to set the database path.
I was obliged to define this method in ewk_view.cpp. In my opinion, we need to
move settgins methods to ewk_settings.cpp. I'd like to listen your opinions
about this patch. :). I was obliged to modify eweblauncher as well.
Thanks,
Gyuyoung Kim.
More information about the webkit-reviews
mailing list