[webkit-reviews] review denied: [Bug 41155] In FrameLoader, m_URL is not set before calling client dispatchDidCommitLoad for cached pages : [Attachment 66890] Patch with spacing in comments fixed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 9 00:56:00 PDT 2010


chris fleizach <cfleizach at apple.com> has denied Dinu Jacob
<dinu.jacob at Nokia.com>'s request for review:
Bug 41155: In FrameLoader, m_URL is not set before calling client
dispatchDidCommitLoad for cached pages
https://bugs.webkit.org/show_bug.cgi?id=41155

Attachment 66890: Patch with spacing in comments fixed
https://bugs.webkit.org/attachment.cgi?id=66890&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 66977)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,18 @@
> +2010-09-08  Jacob Dinu  <dinu.jacob at nokia.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   When loading a cached page, dispatchDidCommitLoad is called after
FrameLoader::open so
> +	   that all initialzations are done before calling client
dispatchDidCommitLoad to avoid

spelling (initialzations)

> +	   client from accessing incorrect data.

grammar
to avoid (the) client

> +


More information about the webkit-reviews mailing list