[webkit-reviews] review denied: [Bug 45427] [EFL] enable UsesEncodingDetector : [Attachment 66974] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 9 00:48:26 PDT 2010


chris fleizach <cfleizach at apple.com> has denied Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 45427: [EFL] enable UsesEncodingDetector
https://bugs.webkit.org/show_bug.cgi?id=45427

Attachment 66974: Patch
https://bugs.webkit.org/attachment.cgi?id=66974&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
> Index: WebKit/efl/ChangeLog
> ===================================================================
> --- WebKit/efl/ChangeLog	(revision 67042)
> +++ WebKit/efl/ChangeLog	(working copy)
> @@ -1,3 +1,15 @@
> +2010-09-08  Ryuan Choi  <ryuan.choi at samsung.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [EFL] enable UsesEncodingDetector
> +	   https://bugs.webkit.org/show_bug.cgi?id=45427
> +
> +	   Enable encodingDetector.
> +

please add a more informative comment as to why you want to enable here. 

and please add a layout test to confirm the desired behavior is now present.


More information about the webkit-reviews mailing list