[webkit-reviews] review granted: [Bug 45408] Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests : [Attachment 66935] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 45408: Include detailed test modifiers (e.g. FLAKY) in results.json for
failing non-layout tests
https://bugs.webkit.org/show_bug.cgi?id=45408

Attachment 66935: Patch
https://bugs.webkit.org/attachment.cgi?id=66935&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66935&action=prettypatch

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator
.py:64
> +	       # Shouldn't happen
If this shouldn't happen, lets just leave out the try/except clause. Otherwise,
if this starts happening, we'll never know. I'd be OK with the try/except
clause if we logged the error (i.e. a warning level log). But, we shouldn't
just silently ignore it.

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:820
>				      individual_test_timings)
Indentation is off by a space.