[webkit-reviews] review granted: [Bug 45287] [chromium] Leak in RenderViewTest::SimulateElementClick() : [Attachment 66787] Shorter patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 45287: [chromium] Leak in RenderViewTest::SimulateElementClick()
https://bugs.webkit.org/show_bug.cgi?id=45287

Attachment 66787: Shorter patch
https://bugs.webkit.org/attachment.cgi?id=66787&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66787&action=prettypatch

> WebKit/chromium/public/WebDOMEvent.h:55
> +    virtual ~WebDOMEvent() { reset(); }
nit: please list the destructor first w/ a new line between it and WebDOMEvent
(as is done in WebNode.h).

I'm also not sure why this destructor needs to be virtual.  This adds a virtual
table to this class.  I notice that WebNode also has a virtual destructor, but
I can't figure out why it should need one either.

R=me, but please consider making the above changes before committing.