[webkit-reviews] review granted: [Bug 44653] don't delete duplicates needed because of intermediate results : [Attachment 65577] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 44653: don't delete duplicates needed because of intermediate results
https://bugs.webkit.org/show_bug.cgi?id=44653

Attachment 65577: Patch
https://bugs.webkit.org/attachment.cgi?id=65577&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=65577&action=prettypatch

Does this do the right thing if the intermediate result is the same as the
current result? e.g. what if there are results for a test in each of
platform/mac, platform-mac-leopard and platform-mac-chromium-leopard, but
they're all the same? The ones the two leopard specific results should be
listed as redundant, right?

It's hard for me to tell from this code whether this does that or not. Can you
add a test for this case? Otherwise, this looks good.