[webkit-reviews] review requested: [Bug 45134] Added statistics sampling and reporting for JavaScriptCore's RegisterFile and ExecutableAllocator classes : [Attachment 66979] Revised patch w/ changes in Mutex use and function renaming

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 8 18:12:09 PDT 2010


John Therrell <jtherrell at apple.com> has asked  for review:
Bug 45134: Added statistics sampling and reporting for JavaScriptCore's
RegisterFile and ExecutableAllocator classes
https://bugs.webkit.org/show_bug.cgi?id=45134

Attachment 66979: Revised patch w/ changes in Mutex use and function renaming
https://bugs.webkit.org/attachment.cgi?id=66979&action=review

------- Additional Comments from John Therrell <jtherrell at apple.com>
Built both debug and release builds without error. Performance testing via
SunSpider confirms no performance regression caused by patch: Ran webkit-tests
without issue. Made changes following review earlier this morning.

With Patch: (SunSpider run 30 times)
--------------------------------------------
Total:		       207.6ms +/- 0.3%
--------------------------------------------


More information about the webkit-reviews mailing list