[webkit-reviews] review granted: [Bug 45412] Fix a problem in createCanonicalUUIDString that causes the last digit missing on Linux : [Attachment 66940] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 8 14:15:21 PDT 2010


Darin Adler <darin at apple.com> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 45412: Fix a problem in createCanonicalUUIDString that causes the last
digit missing on Linux
https://bugs.webkit.org/show_bug.cgi?id=45412

Attachment 66940: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=66940&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>      char uuidStr[37] = {0};

There's no reason to initialize this. The fgets function will fill in the array
including adding the '\0' terminator if it succeeds. And if it fails we don’t
look at the array in our code.


More information about the webkit-reviews mailing list