[webkit-reviews] review granted: [Bug 44722] Add support for "downloadToFile" to ResourceRequest and ResourceResponse : [Attachment 65667] downloadToFile

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Michael Nordman
<michaeln at google.com>'s request for review:
Bug 44722: Add support for "downloadToFile" to ResourceRequest and
ResourceResponse
https://bugs.webkit.org/show_bug.cgi?id=44722

Attachment 65667: downloadToFile
https://bugs.webkit.org/attachment.cgi?id=65667&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=65667&action=prettypatch

> WebCore/ChangeLog:13
> +
shouldn't there also be a change to ResourceHandleClient to similarly add a
didReceiveFileData method?

> WebCore/platform/network/ResourceResponseBase.h:114
> +    // TBD: How is the lifetime of this file is managed?
nit: "file is managed" -> "file managed"

TBD -> FIXME