[webkit-reviews] review granted: [Bug 45310] Support <script async> as specified by HTML5 : [Attachment 66780] Update readystate expectations. Use increment/decrementLoadEventDelayCount()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 8 12:44:42 PDT 2010
Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 45310: Support <script async> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=45310
Attachment 66780: Update readystate expectations. Use
increment/decrementLoadEventDelayCount()
https://bugs.webkit.org/attachment.cgi?id=66780&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66780&action=prettypatch
Looks good to me. It would be good for Eric to look at this change too before
landing.
> WebCore/dom/AsyncScriptRunner.cpp:46
> + m_scriptsToExecuteSoon[i].first->element()->deref(); // Balances
ref() in executeScriptSoon().
Manual ref counting is sadness. Is there no way to do this with RefPtr?
More information about the webkit-reviews
mailing list