[webkit-reviews] review granted: [Bug 44854] MarkupAccumulator should be broken down into two classes : [Attachment 65883] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 44854: MarkupAccumulator should be broken down into two classes
https://bugs.webkit.org/show_bug.cgi?id=44854

Attachment 65883: Patch
https://bugs.webkit.org/attachment.cgi?id=65883&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
> Index: WebCore/ChangeLog
> +	   MarkupAccumulator should be broken down into two classes
> +	   https://bugs.webkit.org/show_bug.cgi?id=44854

Please add a short sentence why we want to have 2 classes (so we can expose
this to webkit so embedders can implement save page).

> Index: WebCore/editing/markup.cpp
> +    String takeResults();
> +protected:

Nit: Add a blank line before protected:

> +    bool shouldAnnotate() { return m_shouldAnnotate ==
AnnotateForInterchange; }
> +private:

Nit: blank line before private: