[webkit-reviews] review requested: [Bug 45318] Complex Path FontCache does not handle SmallCaps properly : [Attachment 66916] Updated patch with LayoutTests

[bugzilla-daemon at webkit.org]

Gary Simmons <gsimmons at rim.com> has asked  for review:
Bug 45318: Complex Path FontCache does not handle SmallCaps properly
https://bugs.webkit.org/show_bug.cgi?id=45318

Attachment 66916: Updated patch with LayoutTests
https://bugs.webkit.org/attachment.cgi?id=66916&action=review

------- Additional Comments from Gary Simmons <gsimmons at rim.com>
I've updated the patch and attached a relevant layout test. This bug only
manifests itself in the Qt port as all other ports are now using the fast path
for fonts. When using the non-fast path code, Small Caps is requested as a
variant attribute in the FontDescription. With the current code, the generated
FontPlatformData object will be indistinguishable (in terms of hash keys) from
the plain variant causing whichever one is used first to become always used.

If the test is manually loaded in the current Qt browser, you'll see all the
text as small caps (which is incorrect as described by the test and
demonstrated by other browsers).

Any ports using the fast path are exempt from this issue as they request the
smallCapsFontData from the SimpleFontData object rather than directly asking
the cache. 

I have generated expected results for Qt but I have not had access to the
resources to generate results for other ports as of yet.