[webkit-reviews] review denied: [Bug 30625] Implement WebGL on Windows : [Attachment 66912] makeContextCurrent, not ensureContext.

[bugzilla-daemon at webkit.org]

Chris Marrin <cmarrin at apple.com> has denied Paul Sawaya <psawaya at apple.com>'s
request for review:
Bug 30625: Implement WebGL on Windows
https://bugs.webkit.org/show_bug.cgi?id=30625

Attachment 66912: makeContextCurrent, not ensureContext.
https://bugs.webkit.org/attachment.cgi?id=66912&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66912&action=prettypatch

> WebCore/platform/graphics/ANGLEWebKitBridge.h:41
> +
Can you remove this extra line to avoid this spurious file in the patch?

> WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:273
> +    CGLSetCurrentContext(m_contextObj);
Need to replace this with makeContextCurrent()

> WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:332
> +    CGLSetCurrentContext(m_contextObj);
Need to replace this with makeContextCurrent()

> WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:45
>  #include <OpenGL/CGLRenderers.h>
You shouldn't need this here, should you? There should be no CGL specific calls
left in this file.

> WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:439
> +
Should get rid of debugging statements like this.