[webkit-reviews] review granted: [Bug 45313] [chromium] Port test shell geolocation fixes to DRT : [Attachment 66867] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Jonathan Dixon
<joth at chromium.org>'s request for review:
Bug 45313: [chromium] Port test shell geolocation fixes to DRT
https://bugs.webkit.org/show_bug.cgi?id=45313

Attachment 66867: Patch
https://bugs.webkit.org/attachment.cgi?id=66867&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66867&action=prettypatch

> WebKit/chromium/src/WebGeolocationServiceMock.cpp:231
> +	       m_pendingPermissionRequests.remove(i);
Is this horribly slow?	Maybe better to swap this with the last item?  Or maybe
it really doesn't matter since this is only for testing code?

> WebKit/chromium/src/WebGeolocationServiceMock.cpp:243
> +	    it != pendingPermissionRequests.end(); ++it) {
dont' wrap