[webkit-reviews] review denied: [Bug 45349] [GTK] testmimehandling falsely succeeds testing Ogg mime type : [Attachment 66862] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 45349: [GTK] testmimehandling falsely succeeds testing Ogg mime type
https://bugs.webkit.org/show_bug.cgi?id=45349

Attachment 66862: proposed patch
https://bugs.webkit.org/attachment.cgi?id=66862&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66862&action=prettypatch

I'm not sure this is the best way to tackle this problem. It doesn't handle the
local case. Isn't it possible to fix MediaPlayerGstreamerPrivate to handle this
mime type?

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:256
> +    GOwnPtr<gchar> mimeType;
It's better to use CString in these cases.