[webkit-reviews] review granted: [Bug 45376] Apply :invalid CSS class to <input type=number> with an unacceptable value : [Attachment 66861] Patch (EWS failure expected)

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 45376: Apply :invalid CSS class to <input type=number> with an unacceptable
value
https://bugs.webkit.org/show_bug.cgi?id=45376

Attachment 66861: Patch (EWS failure expected)
https://bugs.webkit.org/attachment.cgi?id=66861&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66861&action=prettypatch

Ok.

> WebCore/dom/Element.h:284
> +    virtual bool hasUnacceptableValue() const { return false; }
Darin Adler taught me it would be better to have bodies of virtuals in the cpp
files, even inlines. But for consistency with the other methods, I don't think
it makes sense to ask you to redo this.

> WebCore/html/HTMLInputElement.cpp:831
> +    if (inputType() == NUMBER) {
One day we will rework HTMLInputElement to eliminate all this inputType() ==
FOO cruft. But not today.

> WebCore/rendering/RenderTextControlSingleLine.cpp:178
> +	   static_cast<HTMLInputElement*>(input)->setNeedsStyleRecalc();
And we'll remove this cruft too :)