[webkit-reviews] review denied: [Bug 30625] Implement WebGL on Windows : [Attachment 66856] Moved into /mac, build only on Mac

[bugzilla-daemon at webkit.org]

Chris Marrin <cmarrin at apple.com> has denied Paul Sawaya <psawaya at apple.com>'s
request for review:
Bug 30625: Implement WebGL on Windows
https://bugs.webkit.org/show_bug.cgi?id=30625

Attachment 66856: Moved into /mac, build only on Mac
https://bugs.webkit.org/attachment.cgi?id=66856&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66856&action=prettypatch

> WebCore/html/canvas/WebGLObject.cpp:63
> +	       m_context->graphicsContext3D()->ensureContext();
I really want to get rid of ensureContext and make everything use
makeContextCurrent(), which should be a member function implemented by each
platform.

> WebCore/platform/graphics/GraphicsContext3D.h:432
> +    void ensureContext();
Again, why not just use makeContextCurrent(), and have that function (in the
Mac implementation) do the optimization of skipping the set if the context is
already set?

> WebCore/platform/graphics/mac/GraphicsContext3DOpenGL.cpp:1
> +/*
This is not Mac specific. Please make a platform/graphics/opengl subdirectory
and put it there. For now this file will only be included in Mac builds. But
that will change when we do implementations for other platforms.