[webkit-reviews] review denied: [Bug 45286] Web Inspector: use string representation of resource type in extension API : [Attachment 66712] patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 45286: Web Inspector: use string representation of resource type in
extension API
https://bugs.webkit.org/show_bug.cgi?id=45286

Attachment 66712: patch
https://bugs.webkit.org/attachment.cgi?id=66712&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66712&action=prettypatch

> LayoutTests/inspector/extensions-resources.html:47
> +    webInspector.inspectedWindow.evaluate("var xhr = new XMLHttpRequest();
xhr.open('GET', '" + location.href + "', false); xhr.send(null);", callback);
This code can be extracted into a function on the inspected side and then you
would only need to call that function. I guess it might make the code more
clear.

> WebCore/inspector/front-end/ExtensionAPI.js:134
> +var ResourceTypes = {
Could we extract this into a file shared between ExtensionAPI.js and
Resource.js, r- for this.