[webkit-reviews] review granted: [Bug 45364] Fallback content should be rendered when an <object> doesn't specify a data, type or classid attribute. : [Attachment 66850] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 45364: Fallback content should be rendered when an <object> doesn't specify
a data, type or classid attribute.
https://bugs.webkit.org/show_bug.cgi?id=45364

Attachment 66850: Patch
https://bugs.webkit.org/attachment.cgi?id=66850&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> +    // HTML5 says that an object resource's URL is specified by the object's
data
> +    // attribute, not by a param element. However, for compatibility, allow
the
> +    // resource's URL to be given by a param named "src", "movie", "code" or
"url"
> +    // if we know that resource points to a plug-in.
> +    SubframeLoader* loader =
document()->frame()->loader()->subframeLoader();
> +    if (url.isEmpty() && loader->resourceWillUsePlugin(urlParam,
serviceType))
> +	   url = urlParam;
Minor nit, but you don't need the many dereferences to fetch "loader" unless
url is empty.

r=me