[webkit-reviews] review granted: [Bug 45173] [Qt] Refactor MiniBrowser : [Attachment 66489] proposed patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 45173: [Qt] Refactor MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=45173

Attachment 66489: proposed patch
https://bugs.webkit.org/attachment.cgi?id=66489&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66489&action=prettypatch

> WebKitTools/MiniBrowser/qt/BrowserView.cpp:74
> +void BrowserView::load(const QUrl& url)
> +{
> +#if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0)
> +    return m_item->load(QUrl::fromUserInput(url.toString()));
> +#else
> +    return m_item->load(url);
> +#endif
> +}
This function should really be taking a QString as argument, not a QUrl.
QUrl::toString() and then passing it to QUrl::fromUserInput is asking for
trouble :)

That's not your fault though, just a comment on the side. I also think it's
safe to remove the QT_VERSION_CHECK here.