[webkit-reviews] review canceled: [Bug 45365] Remove support for non-lazy attach and fix frames to load from insertedIntoDocument instead of attach : [Attachment 66842] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has canceled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 45365: Remove support for non-lazy attach and fix frames to load from
insertedIntoDocument instead of attach
https://bugs.webkit.org/show_bug.cgi?id=45365

Attachment 66842: Patch
https://bugs.webkit.org/attachment.cgi?id=66842&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This is not actually ready for review yet.  fast/frames/frame-limit.html still
hits an ASSERT, but every other test passes.  fast/frames/frame-limit.html hits
an ASSERT:

void Page::checkFrameCountConsistency() const
{
    ASSERT(m_frameCount >= 0);

    int frameCount = 0;
    for (Frame* frame = mainFrame(); frame; frame =
frame->tree()->traverseNext())
	++frameCount;

    ASSERT(m_frameCount + 1 == frameCount);
}

The frame count is off (too high) by one.  Not sure what is causing this yet.