[webkit-reviews] review granted: [Bug 45351] pushstate-clears-forward-history.html crashes with Chromium DRT : [Attachment 66821] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 7 22:33:47 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 45351: pushstate-clears-forward-history.html crashes with Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45351
Attachment 66821: Patch
https://bugs.webkit.org/attachment.cgi?id=66821&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66821&action=prettypatch
> LayoutTests/fast/loader/stateobjects/popstate-fires-with-page-cache.html:50
> + setTimeout(function() { testWindow.close(); finishJSTest(); },
0);
readability nit:
setTimeout(function() {
testWindow.close();
finishJSTest();
}, 0);
That way it is easy to set breakpoints too in the JS debugger.
More information about the webkit-reviews
mailing list