[webkit-reviews] review requested: [Bug 44954] [WML] Remove create() function in WMLTaskElement because of build breaks. : [Attachment 66837] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 44954: [WML] Remove create() function in WMLTaskElement because of build
breaks.
https://bugs.webkit.org/show_bug.cgi?id=44954

Attachment 66837: Patch
https://bugs.webkit.org/attachment.cgi?id=66837&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
When I modify this patch with your guidance, there are no build break.
As you know, the build break came from the create(). So, if we remove the
create() in WMLTaskElement.cpp, I think we should find which class uses the
create() function. But, I can't find classes which invokes the create() from
WMLTaskElement.cpp. 

>> I'm also confused, that we don't have 'create' for the elements mentioned
above (Go, Prev, Refresh).

The three elements you mentioned have create() functions as below. The create()
of WMLTaskCreate is not invoked by other classes. If we need to make the
create() function for WMLTaskElement, I think we can make it again. For now,
this patch is needed to fix build break. How do you think about it ?


===============================================================================
=================
 53 PassRefPtr<WMLGoElement> WMLGoElement::create(const QualifiedName& tagName,
Document* document)
 54 {

 39 PassRefPtr<WMLPrevElement> WMLPrevElement::create(const QualifiedName&
tagName, Document* document)
 40 {

 40 PassRefPtr<WMLRefreshElement> WMLRefreshElement::create(const
QualifiedName& tagName, Document* document)
 41 {
===============================================================================
=================