[webkit-reviews] review granted: [Bug 45354] chromium/mac: Fix crash with compositor due to missing current NSGraphicsContext : [Attachment 66823] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Nico Weber <thakis at chromium.org>'s
request for review:
Bug 45354: chromium/mac: Fix crash with compositor due to missing current
NSGraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=45354

Attachment 66823: Patch
https://bugs.webkit.org/attachment.cgi?id=66823&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66823&action=prettypatch

Looks good to me. Because I've run into the issue that Chromium doesn't define
PLATFORM(MAC) I'm surprised that we compile in code in the WebCore/platform/mac
directory (LocalCurrentGraphicsContext).

Is there any possibility that LocalCurrentGraphicsContext is leaking its newly
created NSGraphicsContext (by leaving it as the current context) if there isn't
a current NSGraphicsContext going in to the constructor?

> WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:46
> +
Unneeded newline